Add callback switch to mxqsub #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxqsub accepts --callback=SCRIPT (absolute path). The daemon runs the script after every terminal outcome (finished, failed, killed, unknown), as the submitting user in the job workdir, with MXQ_JOB_ID, MXQ_GROUP_ID, MXQ_JOB_STATUS, and MXQ_JOB_WORKDIR in the environment. Adds job_callback column to mxq_job; migration in migrate_019. Also fixes mxq_set_job_status_unknown not updating job->job_status in-struct, inconsistent with the other status-update functions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
donald
requested changes
May 27, 2026
| } | ||
|
|
||
| int status; | ||
| if (waitpid(pid, &status, 0) == -1) { |
Contributor
There was a problem hiding this comment.
Are we blocking the daemon here while the user script does its sleep infinity or whatever?
| @@ -60,6 +60,10 @@ static void print_usage(void) | |||
| " -e, --stderr=FILE set file to capture stderr (default: <stdout>)\n" | |||
| " -u, --umask=MASK set mode to use as umask (default: current umask)\n" | |||
| " -p, --priority=PRIORITY set priority (default: 127)\n" | |||
| " -c, --callback=SCRIPT execute SCRIPT when the job finishes (any outcome)\n" | |||
Contributor
There was a problem hiding this comment.
Technically it doesn't need to be a SCRIPT, because we execl() whatever executable it is, right?
Contributor
|
The callback command is run without any constraint (time, memory, cpu). |
Sign in
to join this conversation on GitHub.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be just AI slop.